Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always use dask_array_type for isinstance calls #3787

Merged
merged 2 commits into from
Feb 23, 2020
Merged

always use dask_array_type for isinstance calls #3787

merged 2 commits into from
Feb 23, 2020

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Feb 21, 2020 •
edited
Loading

This makes sure we use dask_array_type instead of dask_array.Array for isinstance calls.

@keewis
Copy link
Collaborator Author

keewis commented Feb 21, 2020

given that we seem to have quite a few bugs in the dask compatibility code (which only gets called if dask is not installed): would it make sense to add a new CI that works like py38 without dask?

@keewis keewis force-pushed the dask-instance-checks branch from cf626d9 to b6b1ca9 Compare February 21, 2020 15:01
@keewis
Copy link
Collaborator Author

keewis commented Feb 21, 2020

the failing tests should be unrelated

@max-sixty
Copy link
Collaborator

LGTM!

@keewis
Copy link
Collaborator Author

keewis commented Feb 23, 2020

the failing tests still are unrelated, they are either #3783, #3751 or a number of distributed errors I don't understand.

Should we merge this?

@max-sixty
Copy link
Collaborator

LGTM!

@dcherian
Copy link
Contributor

distributed failures are dask/distributed#3491. We should do something I guess :)

@dcherian dcherian merged commit 66625c9 into pydata:master Feb 23, 2020
@keewis keewis deleted the dask-instance-checks branch February 24, 2020 00:10
dcherian added a commit to johnomotani/xarray that referenced this pull request Feb 24, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into fix-contourf-set_…
103657d 
…under

* upstream/master: (71 commits)
  Optimize isel for lazy array equality checking (pydata#3588)
  pin msgpack (pydata#3793)
  concat now handles non-dim coordinates only present in one dataset (pydata#3769)
  Add new h5netcdf backend phony_dims kwarg (pydata#3753)
  always use dask_array_type for isinstance calls (pydata#3787)
  allow formatting the diff of ndarray attributes (pydata#3728)
  Pint support for variables (pydata#3706)
  Format issue template comment as md comment (pydata#3790)
  Avoid running test_open_mfdataset_list_attr without dask (pydata#3780)
  remove seaborn.apionly compatibility (pydata#3749)
  Python 3.8 CI (pydata#3727)
  PKG: Explicitly add setuptools dependency (pydata#3628)
  update whats-new
  Typo in Universal Functions section (pydata#3663)
  Release v0.15.0
  fix setup.cfg
  Documentation fixes (pydata#3732)
  Remove extra && in PR template (pydata#3730)
  Remove garbage text inserted in DASK_LICENSE (pydata#3729)
  Avoid unsafe use of pip (pydata#3726)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Three test_aggregation[int-method_median] tests failing
3 participants
@keewis @max-sixty @dcherian